[Dev] patch for pd include in configure, fix definition.c

jb at integralive.org jb at integralive.org
Tue Apr 8 11:06:37 BST 2008


Hi Stephen,

Henrik wrote:

>> Any objection to me dropping a couple of patches on libintegra?
>>
> No, absolutely not. We're happy for any contributions!

I agree, I'm really excited someone's actually looked at the code!

>> I was compiling it and found I wanted to configure a non-standard
>> location for the Pd headers.  Also, I got a compile error on
>> definition.c.
>>
> Jamie is the authority on the build system, but I can't see why he would
> object.

Stephen, please go ahead and commit this, it was on the to do list anyhow.
Re: autotools -- I'm no expert either, I just wave my hand at it and hope
it works!

> Thanks for spotting the error in the definition.c. I'm surprised I
> didn't get that warning in gcc-4.1.2...

Me too. Anyhow, please don't commit the fix for this one. I've just
committed some changes which actually try to return something sensible ;-)

Henrik, also note that you shouldn't need to check for NULL when using
ntg_free(), because ntg_free() already does that and returns something
sensible if there's a problem.

best,

Jamie







More information about the Dev mailing list